Skip to content
June 24, 2011 / marrowboy

Code reviews

Code reviews indeed. Very useful. I noticed this morning that a code review with two people (coder and reviewer) can feel quite confrontational.

Avoid this by involving more people.

a bad code review

The practice of pairing is helpful but code reviews are important beyond that. One-on-one code reviews feel a bit nasty to me, like the work is being judged in an unfair way. I’m not saying that it *is* nasty, nor that everyone feels the same as I do. But I feel a bit of dread when I’m asked to do an individual code review – what if the other person disagrees with my review comments? They’re often about style, after all.

With 3 or more people any conversation is automatically a consensus-discussion rather than an interrogation, and I think it makes the review lighter and helps with the secondary objective of knowledge-sharing enormously.

Just an observation.

Advertisements

Leave a Reply

Fill in your details below or click an icon to log in:

WordPress.com Logo

You are commenting using your WordPress.com account. Log Out / Change )

Twitter picture

You are commenting using your Twitter account. Log Out / Change )

Facebook photo

You are commenting using your Facebook account. Log Out / Change )

Google+ photo

You are commenting using your Google+ account. Log Out / Change )

Connecting to %s

%d bloggers like this: